feat(gwyneth): add first simple tests for proposer/prover #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 4, 2024 12:00
|
@Brechtpd proposeBlock() works with X amount of iteration but combined with proveBlock() currently it fails. (Can debug later why), but i do have one question. Can you check file BasedOperator.sol and line 149, and my comment in the code ? I'm not sure in that logic, but i also know the original also not perfect, because it will revert with block already proven, so somehow we need to find a way if a block was proven before or not, right ? Thanks ! (if you wanna run, just run : |
Brechtpd
reviewed
Jul 4, 2024
Block hash or meta hash in transition mapping ?
adaki2004
changed the title
Brechtpd
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todos:
proposeBlock()tests (withoutISequencerRegistrytests so fer)proveBlock()